Re: [PATCH] MIPS: c-r4k: Fix size calc when avoiding IPIs for small icache flushes
From: Florian Fainelli
Date: Wed Sep 07 2016 - 19:35:19 EST
On 09/05/2016 07:24 AM, Paul Burton wrote:
> Commit f70ddc07b637 ("MIPS: c-r4k: Avoid small flush_icache_range SMP
> calls") adds checks to force use of hit-type cache ops for small icache
> flushes where they are globalised & index-type cache ops aren't, in
> order to avoid the overhead of IPIs in those cases. However it
> calculated the size of the region being flushed incorrectly, subtracting
> the end address from the start address rather than the reverse. This
> would have led to an overflow with size wrapping round to some large
> value, and likely to the special case for avoiding IPIs not actually
> being hit.
>
> Signed-off-by: Paul Burton <paul.burton@xxxxxxxxxx>
> Cc: James Hogan <james.hogan@xxxxxxxxxx>
> Fixes: f70ddc07b637 ("MIPS: c-r4k: Avoid small flush_icache_range SMP calls")
Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Yes would be good to get that in v4.8.
--
Florian