Re: [PATCH] [media] pci: constify snd_pcm_ops structures

From: Julia Lawall
Date: Wed Sep 07 2016 - 23:08:34 EST




On Thu, 8 Sep 2016, Andrey Utkin wrote:

> Thanks for looking into this.
> I have tested that it compiles and passes checks (C=2) cleanly after
> this patch.
>
> Acked-by: Andrey Utkin <andrey.utkin@xxxxxxxxxxxxxxxxxxx>
>
> While we're at it, what about constification of
> *-core.c:static struct pci_driver *_pci_driver = {
> *-video.c:static struct vb2_ops *_video_qops = {
> *-video.c:static struct video_device *_video_template = {
>
> in drivers/media/pci/? Also there are even more similar entries not
> constified yet in drivers/media/, however I may be underestimating
> complexity of making semantic rules for catching that all.

I will check on these. Thanks for the suggestion.

julia