Re: [PATCH -v3 03/10] mm, memcg: Support to charge/uncharge multiple swap entries

From: Anshuman Khandual
Date: Thu Sep 08 2016 - 04:31:19 EST


On 09/07/2016 10:16 PM, Huang, Ying wrote:
> From: Huang Ying <ying.huang@xxxxxxxxx>
>
> This patch make it possible to charge or uncharge a set of continuous
> swap entries in the swap cgroup. The number of swap entries is
> specified via an added parameter.
>
> This will be used for the THP (Transparent Huge Page) swap support.
> Where a swap cluster backing a THP may be allocated and freed as a
> whole. So a set of continuous swap entries (512 on x86_64) backing one

Please use HPAGE_SIZE / PAGE_SIZE instead of hard coded number like 512.