Re: [PATCH 1/1] intel-mid: Fix sfi get_platform_data() return value issues

[Andy Shevchenko]

On Wed, 2016-09-07 at 17:04 -0700, sathyanarayanan kuppuswamy wrote:

> --- a/arch/x86/platform/intel-mid/sfi.c
> > > +++ b/arch/x86/platform/intel-mid/sfi.c
> > > @@ -335,9 +335,12 @@ static void __init sfi_handle_ipc_dev(struct
> > > sfi_device_table_entry *pentry,
> > > ÂÂ
> > > ÂÂ	pr_debug("IPC bus, name = %16.16s, irq = 0x%2x\n",
> > > ÂÂ		pentry->name, pentry->irq);
> > > +
> > > ÂÂ	pdata = intel_mid_sfi_get_pdata(dev, pentry);
> > > -	if (IS_ERR(pdata))
> > > +	if (IS_ERR(pdata)) {
> > > +		pr_err("ipc_device: %s: invalid platform data\n",
> > > pentry->name);
> > > ÂÂ		return;
> > > +	}
> > This is actually needs more work. We have duplication in sfi.c and
> > platform_ipc.c.
> Yes. But platform_ipc.c implements custom ipc handler for audio ipcÂ
> device. Even though there are duplications between custom handler andÂ
> generic handler in sfi.c, I think its bit early to optimize this. IÂ
> think we should revisit this once we have one more implementation ofÂ
> custom ipc handler.

Definitely it's out of scope for now.

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy