Re: [PATCH 5/7] [v2] arm64: dts: add LS1046A-RDB board support

From: Shawn Guo
Date: Thu Sep 08 2016 - 09:12:52 EST


On Mon, Sep 05, 2016 at 06:01:33PM +0800, shh.xie@xxxxxxxxx wrote:
> +&ifc {
> + status = "okay";

For sake of consistency, please have 'status' at the end of property
list.

Shawn

> + #address-cells = <2>;
> + #size-cells = <1>;
> + /* NAND Flashe and CPLD on board */
> + ranges = <0x0 0x0 0x0 0x7e800000 0x00010000
> + 0x2 0x0 0x0 0x7fb00000 0x00000100>;
> +
> + nand@0,0 {
> + compatible = "fsl,ifc-nand";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + reg = <0x0 0x0 0x10000>;
> + };
> +
> + cpld: board-control@2,0 {
> + compatible = "fsl,ls1046ardb-cpld";
> + reg = <0x2 0x0 0x0000100>;
> + };
> +};