Re: [PATCH] usb: phy: add USB_SUPPORT dependency

[Kishon Vijay Abraham I]

On Wednesday 07 September 2016 03:01 PM, Hans de Goede wrote:
> Hi,
> 
> On 06-09-16 14:54, Arnd Bergmann wrote:
>> The driver now calls of_usb_get_dr_mode_by_phy, which is part of the
>> USB core layer, and it fails to build when that is not provided:
>>
>> drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
>> phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to
>> `of_usb_get_dr_mode_by_phy'
>>
>> We already have a couple of other PHY drivers with a dependency
>> on USB_SUPPORT, so that seems to be the easiest fix here.
>>
>> An alternative would be to adjust the #ifdef in include/linux/usb/of.h
>> to also check for CONFIG_USB_SUPPORT.
>>
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
> 
> Good catch, patch LGTM:
> 
> Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

merged, thanks.

-Kishon
> 
> Regards,
> 
> Hans
> 
> 
> 
>> ---
>>  drivers/phy/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index c42ddf3c8ed8..985dff8558e5 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -260,6 +260,7 @@ config PHY_SUN4I_USB
>>      depends on RESET_CONTROLLER
>>      depends on EXTCON
>>      depends on POWER_SUPPLY
>> +    depends on USB_SUPPORT
>>      select GENERIC_PHY
>>      help
>>        Enable this to support the transceiver that is part of Allwinner
>>