Re: [PATCH v2] gpio/gpiolib: Forbid irqchip default trigger if probed over DT

From: Marc Zyngier
Date: Thu Sep 08 2016 - 13:13:22 EST


On 07/09/16 23:18, Linus Walleij wrote:
> On Wed, Sep 7, 2016 at 10:12 AM, Marc Zyngier <marc.zyngier@xxxxxxx> wrote:
>
>> Using a default trigger is a bad idea if using DT to configure
>> interrupts, as the device's interrupt specifier will always contain
>> the trigger configuration.
>>
>> Let's warn about that particular situation, and revert to not
>> having a default. Hopefully, the couple of drivers still using
>> this feature will quickly be fixed.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
>> ---
>> Send the tested patch this time around...
>
> I got it the first time, don't worry :D

Errrr, the first one didn't even compile (I'm such a moron sometimes).
Please apply this one instead, which has actually been compile-tested.

Sorry for the noise.

Thanks,

M.
--
Jazz is not dead. It just smells funny...