Re: [PATCH 6/6] x86/dumpstack: allow preemption in show_stack_log_lvl() and dump_trace()

From: Ingo Molnar
Date: Fri Sep 09 2016 - 02:11:16 EST



* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> On Thu, Sep 08, 2016 at 09:04:01AM +0200, Ingo Molnar wrote:
> >
> > * Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> >
> > > arch/x86/kernel/dumpstack_32.c | 14 ++++++--------
> >
> > > --- a/arch/x86/kernel/dumpstack_32.c
> > > +++ b/arch/x86/kernel/dumpstack_32.c
> >
> > > +static void *is_softirq_stack(unsigned long *stack);
> > > {
> >
> > FYI, this bit clearly wasn't build tested on 32-bit even once - I'm skipping this
> > patch.
>
> Argh, sorry about that. I did a lot of testing on 32-bit with this
> patch before. I guess I goofed somehow when I split up the patches.

No problem!

Thanks,

Ingo