Re: [PATCH 4/8] ARM: dts: bcm283x: Add a new EMMC pin group from the downstream tree.

From: Gerd Hoffmann
Date: Fri Sep 09 2016 - 04:47:33 EST


On Fr, 2016-09-09 at 10:26 +0200, Gerd Hoffmann wrote:
> Hi,
>
> > No, i thought of the GPIO pull up/down register values:
> >
> > BCM2835_PUD_OFF 0
> > BCM2835_PUD_DOWN 1
> > BCM2835_PUD_UP 2
>
> We can do that, sure (and probably drop the unused "enum
> bcm2835_pinconf_pull" from drivers/pinctrl/bcm/pinctrl-bcm2835.c at the
> same time).
>
> But I fail to see how this is related to the patch discussed, looks like
> a independent issue to me ...

Oops, noticed that emmc_gpio34 uses them while ordering all the entries.

cheers,
Gerd