Re: [PATCH] [SCSI] bnx2fc: mark symbols static where possible

From: Martin K. Petersen
Date: Fri Sep 09 2016 - 07:12:44 EST


>>>>> "Baoyou" == Baoyou Xie <baoyou.xie@xxxxxxxxxx> writes:

Baoyou> We get a few warnings when building kernel with W=1:
Baoyou> drivers/scsi/bnx2fc/bnx2fc_els.c:257:6: warning: no previous
Baoyou> prototype for 'bnx2fc_srr_compl' [-Wmissing-prototypes]
Baoyou> drivers/scsi/bnx2fc/bnx2fc_els.c:367:6: warning: no previous
Baoyou> prototype for 'bnx2fc_rec_compl' [-Wmissing-prototypes]
Baoyou> drivers/scsi/bnx2fc/bnx2fc_fcoe.c:628:5: warning: no previous
Baoyou> prototype for 'bnx2fc_percpu_io_thread' [-Wmissing-prototypes]
Baoyou> drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1413:26: warning: no previous
Baoyou> prototype for 'bnx2fc_interface_create' [-Wmissing-prototypes]
Baoyou> drivers/scsi/bnx2fc/bnx2fc_hwi.c:997:21: warning: no previous
Baoyou> prototype for 'bnx2fc_alloc_work' [-Wmissing-prototypes]
Baoyou> drivers/scsi/bnx2fc/bnx2fc_io.c:1082:5: warning: no previous
Baoyou> prototype for 'bnx2fc_abts_cleanup' [-Wmissing-prototypes] ....

Baoyou> In fact, these functions are only used in the file in which they
Baoyou> are declared and don't need a declaration, but can be made
Baoyou> static. so this patch marks these functions with 'static'.

Applied to 4.9/scsi-queue.

--
Martin K. Petersen Oracle Linux Engineering