Re: [PATCH v2 02/33] Documentation, ABI: Add a document entry for cache id

[Nilay Vaish]

On 8 September 2016 at 14:33, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
> On Thu, 8 Sep 2016, Fenghua Yu wrote:
>> +What:                /sys/devices/system/cpu/cpu*/cache/index*/id
>> +Date:                July 2016
>> +Contact:     Linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>
>> +Description: Cache id
>> +
>> +             The id identifies a hardware cache of the system within a given
>> +             cache index in a set of cache indices. The "index" name is
>> +             simply a nomenclature from CPUID's leaf 4 which enumerates all
>> +             caches on the system by referring to each one as a cache index.
>> +             The (cache index, cache id) pair is unique for the whole
>> +             system.
>> +
>> +             Currently id is implemented on x86. On other platforms, id is
>> +             not enabled yet.
>
> And it never will be available on anything else than x86 because there is
> no other architecture providing CPUID leaf 4 ....
>
> If you want this to be generic then get rid of the x86isms in the
> explanation and describe the x86 specific part seperately.
>

I second tglx here.  Also, I think this patch should be renumbered to
be patch 01/33.  The current 01/33 patch should be 02/33.  That way we
get to read about the definition of cache id first and its use comes
later.

--
Nilay