Re: [RFC v4 10/22] arch/tile/kernel/time: set ->min_delta_ticks and ->max_delta_ticks

From: Chris Metcalf
Date: Fri Sep 09 2016 - 12:58:26 EST


On 9/8/2016 7:21 AM, Nicolai Stange wrote:
Chris Metcalf <cmetcalf@xxxxxxxxxxxx> writes:

On 08/22/2016 07:33 PM, Nicolai Stange wrote:
With the yet to come introduction of NTP correction awareness to the
clockevent core, drivers should report their valid ranges in units of
cycles to the latter.

Currently, the tile's timer clockevent device is initialized as follows:

evt->max_delta_ns = clockevent_delta2ns(MAX_TICK, evt);

and

.min_delta_ns = 1000,

The first one translates to a ->max_delta_ticks value of MAX_TICK.
For the latter, note that the clockevent core will superimpose a
minimum of 1us by itself -- setting ->min_delta_ticks to 1 is safe here.

Initialize ->min_delta_ticks and ->max_delta_ticks with these values.

Signed-off-by: Nicolai Stange <nicstange@xxxxxxxxx>
---
arch/tile/kernel/time.c | 2 ++
1 file changed, 2 insertions(+)
Thanks. Taken into the tile tree.
I thank you for caring, but may I ask you to drop this again?

No problem - I have removed it.

--
Chris Metcalf, Mellanox Technologies
http://www.mellanox.com