Re: [Nbd] [PATCH 0/5] nbd improvements

From: Jens Axboe
Date: Fri Sep 09 2016 - 16:26:58 EST


On 09/09/2016 02:08 PM, Wouter Verhelst wrote:
Hi Jens,

On Thu, Sep 08, 2016 at 02:13:46PM -0600, Jens Axboe wrote:
Not only are these nice performance improvements, it also cleans up the
code a lot and kills crufty old driver code in favor of using the proper
APIs instead. I have applied the series for 4.9.

Please ensure that the comments I made in my other mail are addressed
before you push this to Linus; otherwise this will result in significant
problems for userspace (that it would then be my responsibility to deal
with).

We've got some time to hash this out, before it goes upstream. I agree
on the 'pid' file being an issue, we need to bring that back to avoid
breaking userspace.

For the other part, Josef, did you test the multiple connection setup
against re-connection?

--
Jens Axboe