Re: [PATCH] hwmon: xgene: access mailbox as RAM

From: Hoan Tran
Date: Fri Sep 09 2016 - 16:51:40 EST


On Fri, Sep 9, 2016 at 1:50 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Friday, September 9, 2016 1:43:17 PM CEST Hoan Tran wrote:
>>
>> > * Are you sure you don't need any smp_rmb()/smp_wmb() barriers
>> > between the accesses?
>>
>> No, we don't need a strict read/write during access PCC subspace. Just
>> make sure all access is committed before PCC send message to the
>> platform which done by PCC mailbox driver.
>>
>
> Ok, got it. The PCC mailbox driver presumably uses writel() to
> send the message, and that implies the necessary barrier
> (unlike writel_relaxed), right?

Yes,

Hoan
>
> Arnd
>