Re: [PATCH 1/2] i2c: aspeed: added driver for Aspeed I2C
From: kbuild test robot
Date: Fri Sep 09 2016 - 20:50:16 EST
Hi Brendan,
[auto build test ERROR on wsa/i2c/for-next]
[also build test ERROR on v4.8-rc5 next-20160909]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]
url: https://github.com/0day-ci/linux/commits/Brendan-Higgins/i2c-aspeed-added-driver-for-Aspeed-I2C/20160910-035912
base: https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
config: blackfin-allmodconfig (attached as .config)
compiler: bfin-uclinux-gcc (GCC) 4.6.3
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=blackfin
All errors (new ones prefixed by >>):
drivers/i2c/busses/i2c-aspeed.c:697:1: error: 'aspeed_i2c_of_table' undeclared here (not in a function)
>> drivers/i2c/busses/i2c-aspeed.c:812:1: error: redefinition of '__inittest'
drivers/i2c/busses/i2c-aspeed.c:707:1: note: previous definition of '__inittest' was here
>> drivers/i2c/busses/i2c-aspeed.c:812:1: error: redefinition of 'init_module'
drivers/i2c/busses/i2c-aspeed.c:707:1: note: previous definition of 'init_module' was here
>> drivers/i2c/busses/i2c-aspeed.c:812:1: error: redefinition of '__exittest'
drivers/i2c/busses/i2c-aspeed.c:707:1: note: previous definition of '__exittest' was here
>> drivers/i2c/busses/i2c-aspeed.c:812:1: error: redefinition of 'cleanup_module'
drivers/i2c/busses/i2c-aspeed.c:707:1: note: previous definition of 'cleanup_module' was here
>> drivers/i2c/busses/i2c-aspeed.c:801:1: error: '__mod_of__aspeed_i2c_of_table_device_table' aliased to undefined symbol 'aspeed_i2c_of_table'
>> drivers/i2c/busses/i2c-aspeed.c:801:1: error: '__mod_of__aspeed_i2c_of_table_device_table' aliased to undefined symbol 'aspeed_i2c_of_table'
vim +/__inittest +812 drivers/i2c/busses/i2c-aspeed.c
691
692 static const struct of_device_id aspeed_i2c_bus_of_table[] = {
693 { .compatible = "aspeed,ast2400-i2c-bus", },
694 { .compatible = "aspeed,ast2500-i2c-bus", },
695 { },
696 };
> 697 MODULE_DEVICE_TABLE(of, aspeed_i2c_of_table);
698
699 static struct platform_driver aspeed_i2c_bus_driver = {
700 .probe = aspeed_i2c_probe_bus,
701 .remove = aspeed_i2c_remove_bus,
702 .driver = {
703 .name = "ast-i2c-bus",
704 .of_match_table = aspeed_i2c_bus_of_table,
705 },
706 };
707 module_platform_driver(aspeed_i2c_bus_driver);
708
709 static void aspeed_i2c_controller_irq(struct irq_desc *desc)
710 {
711 struct aspeed_i2c_controller *c = irq_desc_get_handler_data(desc);
712 unsigned long p, status;
713 unsigned int bus_irq;
714
715 status = readl(c->base);
716 for_each_set_bit(p, &status, ASPEED_I2C_NUM_BUS) {
717 bus_irq = irq_find_mapping(c->irq_domain, p);
718 generic_handle_irq(bus_irq);
719 }
720 }
721
722 static int aspeed_i2c_probe_controller(struct platform_device *pdev)
723 {
724 struct aspeed_i2c_controller *controller;
725 struct device_node *np;
726 struct resource *res;
727
728 controller = kzalloc(sizeof(*controller), GFP_KERNEL);
729 if (!controller)
730 return -ENOMEM;
731
732 res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
733 controller->base = devm_ioremap_resource(&pdev->dev, res);
734 if (IS_ERR(controller->base))
735 return PTR_ERR(controller->base);
736
737 controller->irq = platform_get_irq(pdev, 0);
738 if (controller->irq < 0) {
739 dev_err(&pdev->dev, "no platform IRQ\n");
740 return -ENXIO;
741 }
742
743 controller->irq_domain = irq_domain_add_linear(pdev->dev.of_node,
744 ASPEED_I2C_NUM_BUS, &irq_domain_simple_ops, NULL);
745 if (!controller->irq_domain) {
746 dev_err(&pdev->dev, "no IRQ domain\n");
747 return -ENXIO;
748 }
749 controller->irq_domain->name = "ast-i2c-domain";
750
751 irq_set_chained_handler_and_data(controller->irq,
752 aspeed_i2c_controller_irq, controller);
753
754 controller->dev = &pdev->dev;
755
756 platform_set_drvdata(pdev, controller);
757
758 dev_info(controller->dev, "i2c controller registered, irq %d\n",
759 controller->irq);
760
761 for_each_child_of_node(pdev->dev.of_node, np) {
762 int ret;
763 u32 bus_num;
764 char bus_id[sizeof("i2c-12345")];
765
766 /*
767 * Set a useful name derived from the bus number; the device
768 * tree should provide us with one that corresponds to the
769 * hardware numbering. If the property is missing the
770 * probe would fail so just skip it here.
771 */
772
773 ret = of_property_read_u32(np, "bus", &bus_num);
774 if (ret)
775 continue;
776
777 ret = snprintf(bus_id, sizeof(bus_id), "i2c-%u", bus_num);
778 if (ret >= sizeof(bus_id))
779 continue;
780
781 of_platform_device_create(np, bus_id, &pdev->dev);
782 of_node_put(np);
783 }
784
785 return 0;
786 }
787
788 static int aspeed_i2c_remove_controller(struct platform_device *pdev)
789 {
790 struct aspeed_i2c_controller *controller = platform_get_drvdata(pdev);
791
792 irq_domain_remove(controller->irq_domain);
793 return 0;
794 }
795
796 static const struct of_device_id aspeed_i2c_controller_of_table[] = {
797 { .compatible = "aspeed,ast2400-i2c-controller", },
798 { .compatible = "aspeed,ast2500-i2c-controller", },
799 { },
800 };
> 801 MODULE_DEVICE_TABLE(of, aspeed_i2c_of_table);
802
803 static struct platform_driver aspeed_i2c_controller_driver = {
804 .probe = aspeed_i2c_probe_controller,
805 .remove = aspeed_i2c_remove_controller,
806 .driver = {
807 .name = "ast-i2c-controller",
808 .of_match_table = aspeed_i2c_controller_of_table,
809 },
810 };
811
> 812 module_platform_driver(aspeed_i2c_controller_driver);
813
814 MODULE_AUTHOR("Brendan Higgins <brendanhiggins@xxxxxxxxxx>");
815 MODULE_DESCRIPTION("Aspeed I2C Bus Driver");
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: Binary data