Re: [PATCH] Add additional Intel CPU models to crystal_khz whitelist

From: Thomas Gleixner
Date: Sat Sep 10 2016 - 02:38:07 EST

On Fri, 9 Sep 2016, Prarit Bhargava wrote:

> In commit aa297292d708 ("x86/tsc: Enumerate SKL cpu_khz and tsc_khz via

You cite a commit here, which is nice. If you look at the commit message
then you will notice that _before_ the sentence describing the commit there
is a prefix, which denotes the subsystem to which this patch applies. But
you insist on sending patches w/o a prefix.

Can you please stop this? It's annoying because I have to figure out where
the patch belongs to and have to edit the subject line before applying the

> @@ -688,11 +688,19 @@ unsigned long native_calibrate_tsc(void)
> switch (boot_cpu_data.x86_model) {
> case 0x4E: /* SKL */
> case 0x5E: /* SKL */
> + case 0x8E: /* KBL */
> + case 0x9E: /* KBL */

asm/intel-family.h provides proper defines for this. And before you add
those, please make a seperate patch which converts the existing hex
constants to the defines.