Re: [PATCH] net: ip, diag -- Add diag interface for raw sockets

From: Cyrill Gorcunov
Date: Sat Sep 10 2016 - 15:31:20 EST


On Sat, Sep 10, 2016 at 10:31:35AM -0600, David Ahern wrote:
> On 9/9/16 12:26 PM, Cyrill Gorcunov wrote:
> > In criu we are actively using diag interface to collect sockets
> > present in the system when dumping applications. And while for
> > unix, tcp, udp[lite], packet, netlink it works as expected,
> > the raw sockets do not have. Thus add it.
> >
> > CC: David S. Miller <davem@xxxxxxxxxxxxx>
> > CC: Eric Dumazet <eric.dumazet@xxxxxxxxx>
> > CC: Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>
> > CC: James Morris <jmorris@xxxxxxxxx>
> > CC: Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>
> > CC: Patrick McHardy <kaber@xxxxxxxxx>
> > CC: Andrey Vagin <avagin@xxxxxxxxxx>
> > CC: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
> > ---
>
> Would you mind adding the destroy capability as well? The udp version should be close to
> what is needed for raw sockets. See udp_diag_destroy and udp_abort.

Sure, will do.