Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller

From: Christoph Hellwig
Date: Sun Sep 11 2016 - 09:34:37 EST


On Sat, Sep 10, 2016 at 11:01:51AM -0600, Jason Gunthorpe wrote:
> Sadly, it isn't a step backwards, it is status quo - at least as far
> as the uapi is concerned.

Sort of, see below:

> struct mlx5_create_cq {
> struct ibv_create_cq ibv_cmd;
> __u64 buf_addr;
> __u64 db_addr;
> __u32 cqe_size;
> };
>
> struct iwch_create_cq {
> struct ibv_create_cq ibv_cmd;
> uint64_t user_rptr_addr;
> };
>
> Love to hear ideas on a way forward that doesn't involve rewriting
> everything :(

We stil always have the common structure first. And at least for
cgroups supports that's what matters.

Re the actual structures - we'll really need to make sure we

a) expose proper userspace abi headers in the kernel for all code
in the RDMA subsystem
b) actually use that in the userspace components

I've posted some initial work toward a) a while ago, and once we
agree on adopting your common repo I'd really like to start through
with that work. I think it's a pre-requisite for any major new
userspace ABI work.