Re: [PATCH] IB/rdmavt: free the userspace memory region with kfree instead of vfree

From: Leon Romanovsky
Date: Mon Sep 12 2016 - 00:52:19 EST


On Fri, Sep 09, 2016 at 08:15:37AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The userspace memory region 'mr' is allocated with kzalloc in
> __rvt_alloc_mr however it is incorrectly being freed with vfree in
> __rvt_free_mr. Fix this by using kfree to free it.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>

> ---
> drivers/infiniband/sw/rdmavt/mr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rdmavt/mr.c b/drivers/infiniband/sw/rdmavt/mr.c
> index 80c4b6b..46b6497 100644
> --- a/drivers/infiniband/sw/rdmavt/mr.c
> +++ b/drivers/infiniband/sw/rdmavt/mr.c
> @@ -294,7 +294,7 @@ static void __rvt_free_mr(struct rvt_mr *mr)
> {
> rvt_deinit_mregion(&mr->mr);
> rvt_free_lkey(&mr->mr);
> - vfree(mr);
> + kfree(mr);
> }
>
> /**
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: PGP signature