Re: [PATCH V4] mm: Add sysfs interface to dump each node's zonelist information

From: Anshuman Khandual
Date: Mon Sep 12 2016 - 01:27:41 EST


On 09/09/2016 01:54 AM, Dave Hansen wrote:
> On 09/07/2016 07:46 PM, Anshuman Khandual wrote:
>> > after memory or node hot[un]plug is desirable. This change adds one
>> > new sysfs interface (/sys/devices/system/memory/system_zone_details)
>> > which will fetch and dump this information.
> Doesn't this violate the "one value per file" sysfs rule? Does it
> belong in debugfs instead?

Yeah sure. Will make it a debugfs interface.

>
> I also really question the need to dump kernel addresses out, filtered
> or not. What's the point?

Hmm, thought it to be an additional information. But yes its additional
and can be dropped.