Re: [PATCH 2/6] mfd: sm501: constify gpio_chip structures

[Lee Jones]

On Sun, 11 Sep 2016, Julia Lawall wrote:

> These structures are only used to copy into other structures, so declare
> them as const.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct gpio_chip i@p = { ... };
> 
> @ok@
> identifier r.i;
> expression e;
> position p;
> @@
> e = i@p;
> 
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct gpio_chip e;
> @@
> e@i@p
> 
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct gpio_chip i = { ... };
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@xxxxxxx>
> 
> ---
>  drivers/mfd/sm501.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
> index 65cd0d2..4053435 100644
> --- a/drivers/mfd/sm501.c
> +++ b/drivers/mfd/sm501.c
> @@ -1001,7 +1001,7 @@ static int sm501_gpio_output(struct gpio_chip *chip,
>  	return 0;
>  }
>  
> -static struct gpio_chip gpio_chip_template = {
> +static const struct gpio_chip gpio_chip_template = {
>  	.ngpio			= 32,
>  	.direction_input	= sm501_gpio_input,
>  	.direction_output	= sm501_gpio_output,
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog