Re: [PATCH] net: dsa: add FIB support

From: kbuild test robot
Date: Mon Sep 12 2016 - 08:05:59 EST

Hi John,

[auto build test WARNING on net-next/master]
[also build test WARNING on next-20160912]
[cannot apply to v4.8-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
[Suggest to use git(>=2.9.0) format-patch --base=<commit> (or --base=auto for convenience) to record what (public, well-known) commit your patch series was built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url: https://github.com/0day-ci/linux/commits/John-Crispin/net-dsa-add-FIB-support/20160912-190416
config: i386-randconfig-x011-09112120 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386

All warnings (new ones prefixed by >>):

In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/linux/list.h:4,
from net/dsa/slave.c:11:
net/dsa/slave.c: In function 'dsa_slave_ipv4_fib_add':
net/dsa/slave.c:345:9: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^
include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> net/dsa/slave.c:345:2: note: in expansion of macro 'if'
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^~
net/dsa/slave.c:345:39: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^
include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> net/dsa/slave.c:345:2: note: in expansion of macro 'if'
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^~
net/dsa/slave.c:345:9: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^
include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> net/dsa/slave.c:345:2: note: in expansion of macro 'if'
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^~
net/dsa/slave.c:345:39: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^
include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> net/dsa/slave.c:345:2: note: in expansion of macro 'if'
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^~
net/dsa/slave.c:345:9: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^
include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> net/dsa/slave.c:345:2: note: in expansion of macro 'if'
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^~
net/dsa/slave.c:345:39: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^
include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
>> net/dsa/slave.c:345:2: note: in expansion of macro 'if'
if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
^~
net/dsa/slave.c:349:11: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
ret = ds->drv->ipv4_fib_prepare(ds, p->port, fib4, trans);
^~
net/dsa/slave.c:351:11: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
ret = ds->drv->ipv4_fib_add(ds, p->port, fib4, trans);
^~
In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/linux/list.h:4,
from net/dsa/slave.c:11:
net/dsa/slave.c: In function 'dsa_slave_ipv4_fib_del':
net/dsa/slave.c:363:8: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
if (ds->drv->ipv4_fib_del)
^
include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
net/dsa/slave.c:363:2: note: in expansion of macro 'if'
if (ds->drv->ipv4_fib_del)
^~
net/dsa/slave.c:363:8: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
if (ds->drv->ipv4_fib_del)
^
include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
net/dsa/slave.c:363:2: note: in expansion of macro 'if'
if (ds->drv->ipv4_fib_del)
^~
net/dsa/slave.c:363:8: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
if (ds->drv->ipv4_fib_del)
^
include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
______r = !!(cond); \
^~~~
net/dsa/slave.c:363:2: note: in expansion of macro 'if'
if (ds->drv->ipv4_fib_del)
^~
net/dsa/slave.c:364:11: error: 'struct dsa_switch' has no member named 'drv'; did you mean 'dev'?
ret = ds->drv->ipv4_fib_del(ds, p->port, fib4);
^~

vim +/if +345 net/dsa/slave.c

329 struct dsa_switch *ds = p->parent;
330
331 if (ds->ops->port_mdb_dump)
332 return ds->ops->port_mdb_dump(ds, p->port, mdb, cb);
333
334 return -EOPNOTSUPP;
335 }
336
337 static int dsa_slave_ipv4_fib_add(struct net_device *dev,
338 const struct switchdev_obj_ipv4_fib *fib4,
339 struct switchdev_trans *trans)
340 {
341 struct dsa_slave_priv *p = netdev_priv(dev);
342 struct dsa_switch *ds = p->parent;
343 int ret;
344
> 345 if (!ds->drv->ipv4_fib_prepare || !ds->drv->ipv4_fib_add)
346 return -EOPNOTSUPP;
347
348 if (switchdev_trans_ph_prepare(trans))
349 ret = ds->drv->ipv4_fib_prepare(ds, p->port, fib4, trans);
350 else
351 ret = ds->drv->ipv4_fib_add(ds, p->port, fib4, trans);
352
353 return ret;

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data