Re: [PATCH 2/4] cpu: expose pm_qos_resume_latency for each cpu

From: Ulf Hansson
Date: Tue Sep 13 2016 - 03:17:24 EST

On 13 September 2016 at 03:04, Alex Shi <alex.shi@xxxxxxxxxx> wrote:
> Cc Rafael.
> On 09/01/2016 05:26 PM, Ulf Hansson wrote:
>> In general I think the change makes sense, although it's this last
>> piece here that I wonder about.
>> Is it okay that we expose sysfs attributes to userspace that don't
>> have any effect if they change the values? Perhaps it should be the
>> responsibility of the menu governor somehow to expose the sysfs nodes
>> instead? Unless there are some difficulties that prevents us from that
>> of course.
> Hi Ulf,
> Sorry for response so late. The pm QoS designed to expose this interface
> in userspace. Root user can change this value and made effect on device
> sleeping status. That's required.

Sure, I understand that. Although, my point is that it's only when the
menu governor is enabled, that it would make sense for userspace to
modify the PM QoS values for the cpu device.

> Since this is per device interface, set it on menu governor isn't so good.

You may be right, and it's not a big deal for me! It was just an idea.

Kind regards