Re: [PATCH 2/3] ARM64: dts: amlogic: Add basic support for Amlogic S905X
From: Neil Armstrong
Date: Tue Sep 13 2016 - 03:36:08 EST
On 09/13/2016 08:14 AM, Carlo Caione wrote:
> On Mon, Sep 12, 2016 at 11:43 PM, Andreas FÃrber <afaerber@xxxxxxx> wrote:
>
> [cut]
>> I'm not arguing over the file name, where it perfectly makes sense to
>> have a meson-gxl- prefix (already discussed), just about the compatible
>> string where we don't have "amlogic,meson-gxl-s905x-p231" either because
>> it is completely unnecessary and does _not_ add any value.
>>
>> Not that we're checking this string anywhere anyway... If you want to
>> check for the GXL family you have to use "amlogic,meson-gxl"; if you
>> want to check for the specific SoC you use "amlogic,s905x". Simple. We
>> never match partial strings, so there is no sense in a hardcoded prefix
>> that is duplicating information already available.
>
> Ok, then. Fine with me.
>
> Neil, do you want to resend my patch or you can take care of the fixes
> for the whole patchset?
>
> Thanks,
>
Ok, I still need to synchronize with kevin for when and where to rebase from.
Neil