Re: [PATCH v2 0/4] ARM: amlogic: Add spifc support to Amlogic's GXBB family

[jbrunet]

On Mon, 2016-09-12 at 13:38 -0700, Kevin Hilman wrote:
> Jerome Brunet <jbrunet@xxxxxxxxxxxx> writes:
> 
> > 
> > This patch series adds the necessary pins, clocks and device tree
> > nodes to
> > enable the spifc controller on the GXBB family. I had to add the
> > nand pins
> > in pintctrl as the pinmux setting left by u-boot was conflicting
> > with the
> > spifc pinmux during my test on the P200.
> 
> This series seems to be missing a patch which enables the SPIfc on
> the
> P200 board for use with the on-board NOR flash.
> 
> Kevin
> 

Indeed, I did not provide this patch, on purpose.
The SPI-NOR at 4U2 on the P200 schematics was not present on the board
I have. I assumed this was the case for all other P200 as well.

In addition, to enable the SPI-NOR, you would also need to solder
something at 4R3 (SPI_CS signal disconnected by default)

Finally, all the SPIfc lines are shared with the NAND controller which,
like the SPI-NOR, appears on the schematics (4CCN1) but is not soldered
on the actual hardware.

Of course, I can share such patch for testing purposes if you would
like me to.

Jerome.

> > 
> > Changes since v1 at : http://lkml.kernel.org/r/1473261223-15412-1-g
> > it-send-email-jbrunet@xxxxxxxxxxxx
> > Â* Omit patches :
> > Â - dt-bindings: spi-meson: Add GXBB Compatible string
> > Â - spi: meson: Add GXBB compatible
> > Â Sent as dedicated series
> > Â* Omit patch:
> > Â - clk: gxbb: expose spifc clock
> > Â Already applied
> > Â* Rename SPI flash controller pins from spifc_* to nor_* to keep
> > the
> > ÂÂÂname aligned with the datasheet
> > 
> > Jerome Brunet (3):
> > Â pinctrl: amlogic: gxbb: add spi nor pins
> > Â pinctrl: amlogic: gxbb: add nand pins
> > Â ARM64: dts: amlogic: add spi nor pins
> > 
> > Neil Armstrong (1):
> > Â ARM64: dts: meson-gxbb: Add SPIFC node
> > 
> > Âarch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 19 +++++++++++++++
> > Âdrivers/pinctrl/meson/pinctrl-meson-gxbb.cÂÂ| 37
> > +++++++++++++++++++++++++++++
> > Â2 files changed, 56 insertions(+)