Re: [RESEND RFC PATCH 0/5] platform drivers for UP Board

[Andy Shevchenko]

On Mon, 2016-07-04 at 17:07 +0100, Dan O'Donovan wrote:
> [Re-sending to a wider audience suggested by Darren Hart]
> 
> The UP Board is a new SBC based on the Intel Atom X5-Z8350 "CherryÂ
> Trail" SoC and features a 40-pin I/O pin header and form-factorÂ
> inspired by the Raspberry Pi 2.
> 
> It utilises a CPLD between the SoC and the external 40-pin header
> to provide buffered voltage level-shifting of the I/O signals, mux
> switching and LED control, and programmable pin mapping between the
> SoC and the external pin header.
> 
> The gpio, pinctrl and led drivers provided in this patch seriesÂ
> enable and manage the functions provided by that CPLD.
> 
> I have some open questions about this patch series:
> Â* Is it ok to place all of these various UP board drivers together
> ÂÂÂin drivers/platform/x86/, or would it be preferable to place them
> ÂÂÂin the respective sub-system directories (gpio, pinctrl, etc.)?
> ÂÂÂMy rationale for keeping them together here is that they are all
> ÂÂÂspecific to this UP Board platform and not expected to be
> ÂÂÂgenerally useful on any other platforms (except variants of UP).
> Â* Is it acceptable to include hard-coded references to ACPI device
> ÂÂÂIDs (representing devices integrated on the SoC devices) for the
> ÂÂÂpurpose of pin map and gpio references? Or is it required to
> ÂÂÂuse only named gpio pins?
> 
> Any feedback/suggestions on the questions above, and the patch series
> in general, would be greatly appreciated!

Looking closer to this and taking into account what is going on with
ACPI support for open connected boards I think this patch set is not
needed at all.

Basically most (everything?) you are trying to do in C code may and
should be done in ASL.

Mika, can you correct me if I'm wrong?

> 
> Further information on the UP board can be obtained from [1] and [2].
> 
> [1] https://www.up-board.org
> [2] https://up-community.org
> 
> Dan O'Donovan (5):
> Â platform: x86: add driver for UP Board I/O CPLD
> Â platform: x86: add UP Board I/O pinctrl driver
> Â platform: x86: add UP Board I/O gpio driver
> Â platform: x86: add UP Board CPLD LED driver
> Â platform: x86: add platform driver for UP Board
> 
> Âdrivers/platform/x86/KconfigÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ13 +
> Âdrivers/platform/x86/MakefileÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ5 +
> Âdrivers/platform/x86/up_board.cÂÂÂÂÂÂÂÂÂ| 167 ++++++++++
> Âdrivers/platform/x86/up_board_cpld.cÂÂÂÂ| 560
> ++++++++++++++++++++++++++++++++
> Âdrivers/platform/x86/up_board_cpld.hÂÂÂÂ|ÂÂ38 +++
> Âdrivers/platform/x86/up_board_gpio.cÂÂÂÂ| 254 +++++++++++++++
> Âdrivers/platform/x86/up_board_gpio.hÂÂÂÂ|ÂÂ59 ++++
> Âdrivers/platform/x86/up_board_leds.cÂÂÂÂ|ÂÂ85 +++++
> Âdrivers/platform/x86/up_board_leds.hÂÂÂÂ|ÂÂ50 +++
> Âdrivers/platform/x86/up_board_pinctrl.c | 285 ++++++++++++++++
> Âdrivers/platform/x86/up_board_pinctrl.h | 102 ++++++
> Â11 files changed, 1618 insertions(+)
> Âcreate mode 100644 drivers/platform/x86/up_board.c
> Âcreate mode 100644 drivers/platform/x86/up_board_cpld.c
> Âcreate mode 100644 drivers/platform/x86/up_board_cpld.h
> Âcreate mode 100644 drivers/platform/x86/up_board_gpio.c
> Âcreate mode 100644 drivers/platform/x86/up_board_gpio.h
> Âcreate mode 100644 drivers/platform/x86/up_board_leds.c
> Âcreate mode 100644 drivers/platform/x86/up_board_leds.h
> Âcreate mode 100644 drivers/platform/x86/up_board_pinctrl.c
> Âcreate mode 100644 drivers/platform/x86/up_board_pinctrl.h
> 

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy