Re: [PATCH] ath10k: Spelling and miscellaneous neatening

From: Valo, Kalle
Date: Tue Sep 13 2016 - 08:43:19 EST


Joe Perches <joe@xxxxxxxxxxx> writes:

> Correct some trivial comment typos.
> Remove unnecessary parentheses in a long line.
> Convert a return; before the end of a void function definition to just ;
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

[...]

> --- a/drivers/net/wireless/ath/ath10k/core.c
> +++ b/drivers/net/wireless/ath/ath10k/core.c
> @@ -2118,7 +2118,7 @@ err:
> /* TODO: It's probably a good idea to release device from the driver
> * but calling device_release_driver() here will cause a deadlock.
> */
> - return;
> + ;
> }

I don't think this improves anything, I dropped this part from the patch
in my pending branch.

--
Kalle Valo