Re: [PATCH v3 2/7] mach-aspeed: Select GPIO driver

From: Joel Stanley
Date: Tue Sep 13 2016 - 08:44:10 EST


On Tue, Aug 30, 2016 at 5:25 PM, Andrew Jeffery <andrew@xxxxxxxx> wrote:
> diff --git a/arch/arm/mach-aspeed/Kconfig b/arch/arm/mach-aspeed/Kconfig
> index f3f8c5c658db..5aba9598f821 100644
> --- a/arch/arm/mach-aspeed/Kconfig
> +++ b/arch/arm/mach-aspeed/Kconfig
> @@ -7,6 +7,8 @@ menuconfig ARCH_ASPEED
> select MOXART_TIMER
> select MFD_SYSCON
> select PINCTRL
> + select GPIOLIB
> + select GPIO_ASPEED

GPIO_ASPEED is a tristate, so if we select it in ARCH_ASPEED all users
of the driver will have it selected.

I think I will drop this patch so we still have the option of building
the gpio driver as a module. Otherwise, we should change the GPIO
driver to be built in.

Cheers,

Joel