Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver

[Paul Gortmaker]

[Re: [PATCH v7] gpio: add Intel WhiskeyCove PMIC GPIO driver] On 13/09/2016 (Tue 17:35) Andy Shevchenko wrote:

> On Tue, Sep 13, 2016 at 4:37 PM, Paul Gortmaker
> <paul.gortmaker@xxxxxxxxxxxxx> wrote:
> >> > This looks like an invalid address, and ....
> >>
> >> >> +MODULE_AUTHOR("Ajay Thomas <ajay.thomas.david.rajamanickam@xxxxxxxxx>");
> >> >
> >> > ...the same here.  In fact it sure looks like two names.  Anyway I just got a
> >> > bounce when I tried to use it...
> >>
> >> It might be that person is no longer working for Intel, though I think
> >> It would be better log message for that.
> >
> > That might make sense if the driver was old, but it hasn't even hit
> > mainline yet -- it is only in linux-next, so it cant be more than a few
> > weeks old.
> 
> It's already quite off topic, so, I would just say that it is still
> valid point. Starting from some version of the series (which takes
> couple of months?) Bin Gao did improvements.

Not sure why you would call it off topic -- a new driver appearing in
mainline should have a valid author entry, and if it is an accidental
merge of two names into one then Bin Gao is the person who can ack that
and subsequently fix it.

P.
--

> 
> -- 
> With Best Regards,
> Andy Shevchenko