Re: [PATCH 4/4] input: serio: Replace timeval by timespec64

From: Arnd Bergmann
Date: Tue Sep 13 2016 - 11:13:58 EST


On Tuesday, September 13, 2016 7:10:05 AM CEST Deepa Dinamani wrote:
> struct timeval is not y2038 safe.
> All references to timeval will be deleted from the
> kernel to make it y2038 safe.
> Replace its uses by y2038 safe struct timespec64.
>
> The timestamps changed here only keep track of delta
> times. These timestamps are also internal to kernel.
> Hence, monotonic times are sufficient here.
> The unit of the delta times is also changed in certain
> cases to nanoseconds rather than microseconds. This is
> in line with timespec64 which keeps time in nanoseconds.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@xxxxxxxxx>
>

Looks all correct to me,

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

I think it could be done a little nicer using ktime_get()
instead of ktime_get_ts64(), but probably nobody cares with
this driver.

Arnd