Re: [PATCH 3/3] net-next: dsa: add new driver for qca8xxx family

From: Andrew Lunn
Date: Tue Sep 13 2016 - 11:59:37 EST


> Hi Andrew,
>
> this function does indeed duplicate the functionality of
> phy_ethtool_get_eee() with the small difference, that e->eee_active is
> also set which phy_ethtool_get_eee() does not set.
>
> dsa_slave_get_eee() will call phy_ethtool_get_eee() right after the
> get_eee() op has been called. would it be ok to move the code setting
> eee_active to phy_ethtool_get_eee().

Hi John

I think that is a question for Florian.

Andrew