Re: [PATCH] MIPS: rb532: Fix undefined reference to setup_serial_port

From: Ralf Baechle
Date: Tue Sep 13 2016 - 12:03:01 EST


On Mon, Sep 05, 2016 at 05:18:40PM +0100, Matt Redfearn wrote:

> If the rb532 machine is compiled without CONFIG_SERIAL_8250, the
> following linker error occurs
>
> arch/mips/built-in.o: In function `setup_serial_port':
> (.init.text+0x20c): undefined reference to `early_serial_setup'
>
> Fix this by wrapping registration of the rb532 uart in an ifdef
> CONFIG_SERIAL_8250.

This will still fail if CONFIG_SERIAL_8250 = m.

RB532 should be rewritten to use earl console rather than early_serial_setup
similar to https://git.linux-mips.org/cgit/ralf/linux.git/commit/?id=194d315da86af504559a8a21026360097575bd55
for example.

Ralf