Re: [PATCH] xen: consolidate swiotbl_xen dma_ops

From: Ingo Molnar
Date: Tue Sep 13 2016 - 14:37:35 EST



* Christoph Hellwig <hch@xxxxxx> wrote:

> On Mon, Sep 12, 2016 at 01:45:40PM +0200, Ingo Molnar wrote:
> > Please organize such initializers better! Something like this:
>
> > Makes it much easier to review such definitions.
>
> That's my personal preference, too. But this is just moving/consolidating
> code, so I don't plan to do fancy moves.

I can be passive-aggressive too, so:

NAKed-by: Ingo Molnar <mingo@xxxxxxxxxx>

If the ugliness that makes the patch much harder to review than it should be is
fixed in the same patch or in a different patch then:

Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>

Thanks,

Ingo