Re: [PATCH v2 07/33] x86/intel_rdt: Add support for Cache Allocation detection

From: Dave Hansen
Date: Tue Sep 13 2016 - 18:40:26 EST


On 09/08/2016 02:57 AM, Fenghua Yu wrote:
> --- a/arch/x86/include/asm/disabled-features.h
> +++ b/arch/x86/include/asm/disabled-features.h
> @@ -57,6 +57,7 @@
> #define DISABLED_MASK15 0
> #define DISABLED_MASK16 (DISABLE_PKU|DISABLE_OSPKE)
> #define DISABLED_MASK17 0
> -#define DISABLED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 18)
> +#define DISABLED_MASK18 0
> +#define DISABLED_MASK_CHECK BUILD_BUG_ON_ZERO(NCAPINTS != 19)

Are you sure you don't want to add RDT to disabled-features.h? You have
a config option for it, so it seems like you should also be able to
optimize some of these checks away when the config option is off.