Re: [PATCH] crypto: squash lines for simple wrapper functions
From: Joe Perches
Date: Tue Sep 13 2016 - 22:29:32 EST
On Wed, 2016-09-14 at 11:10 +0900, Masahiro Yamada wrote:
> 2016-09-13 4:44 GMT+09:00 Joe Perches <joe@xxxxxxxxxxx>:
> > On Tue, 2016-09-13 at 04:27 +0900, Masahiro Yamada wrote:
> > > Remove unneeded variables and assignments.
> > Was this found by visual inspection or some tool?
> > If it's via a tool, it's good to mention that in the changelog.
> I used Coccinelle, but I did not mention it
> in case somebody may say "then, please provide your semantic patch".
> As a Coccinelle beginner, I do not want to expose my stupid semantic patch.
If you get it "exposed", you'd likely learn something from others
that would give a few suggestions/tips on how to improve it.