Re: [PATCH v14 01/15] selftests/powerpc: Add more SPR numbers, TM & VMX instructions to 'reg.h'

[Cyril Bur]

On Mon, 2016-09-12 at 15:33 +0800, wei.guo.simon@xxxxxxxxx wrote:
> From: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
> 
> This patch adds SPR number for TAR, PPR, DSCR special
> purpose registers. It also adds TM, VSX, VMX related
> instructions which will then be used by patches later
> in the series.
> 
> Signed-off-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Simon Guo <wei.guo.simon@xxxxxxxxx>
> ---
> Âtools/testing/selftests/powerpc/reg.h | 42
> ++++++++++++++++++++++++++++++++---
> Â1 file changed, 39 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/testing/selftests/powerpc/reg.h
> b/tools/testing/selftests/powerpc/reg.h
> index fddf368..fee7be9 100644
> --- a/tools/testing/selftests/powerpc/reg.h
> +++ b/tools/testing/selftests/powerpc/reg.h
> @@ -18,6 +18,19 @@
> Â
> Â#define mb()		asm volatile("sync" : : : "memory");
> Â
> +/* Vector Instructions */
> +#define VSX_XX1(xs, ra, rb)	(((xs) & 0x1f) << 21 | ((ra) <<
> 16) |ÂÂ\
> +				Â((rb) << 11) | (((xs) >> 5)))
> +#define STXVD2X(xs, ra, rb)	.long (0x7c000798 | VSX_XX1((xs),
> (ra), (rb)))
> +#define LXVD2X(xs, ra, rb)	.long (0x7c000698 | VSX_XX1((xs),
> (ra), (rb)))

Theres an instructions.h file in tools/testing/selftests/powerpc/ would
these be better suited there?

> +
> +/* TM instructions */
> +#define TBEGIN		".long 0x7C00051D;"
> +#define TABORT		".long 0x7C00071D;"
> +#define TEND		".long 0x7C00055D;"
> +#define TSUSPEND	".long 0x7C0005DD;"
> +#define TRESUME		".long 0x7C2005DD;"
> +

These are only useful on old compilers that don't know about TM. For
selftests I would discourage creating these and using the actual
instructions, they are fairly well known today by most compilers.

> Â#define SPRN_MMCR2ÂÂÂÂÂ769
> Â#define SPRN_MMCRAÂÂÂÂÂ770
> Â#define SPRN_MMCR0ÂÂÂÂÂ779
> @@ -51,10 +64,33 @@
> Â#define SPRN_SDARÂÂÂÂÂÂ781
> Â#define SPRN_SIERÂÂÂÂÂÂ768
> Â
> -#define SPRN_TEXASRÂÂÂÂÂ0x82
> +#define SPRN_TEXASRÂÂÂÂÂ0x82ÂÂÂÂ/* Transaction Exception and Status
> Register */
> Â#define SPRN_TFIARÂÂÂÂÂÂ0x81ÂÂÂÂ/* Transaction Failure Inst
> AddrÂÂÂÂ*/
> Â#define SPRN_TFHARÂÂÂÂÂÂ0x80ÂÂÂÂ/* Transaction Failure Handler Addr
> */
> -#define TEXASR_FSÂÂÂÂÂÂÂ0x08000000
> -#define SPRN_TARÂÂÂÂÂÂÂÂ0x32f
> +#define SPRN_TARÂÂÂÂÂÂÂÂ0x32f	/* Target Address Register */
> +
> +#define SPRN_DSCR_PRIV 0x11	/* Privilege State DSCR */
> +#define SPRN_DSCRÂÂÂÂÂÂ0x03	/* Data Stream Control Register
> */
> +#define SPRN_PPRÂÂÂÂÂÂÂ896	/* Program Priority Register */
> +
> +/* TEXASR register bits */
> +#define TEXASR_FC	0xFE00000000000000
> +#define TEXASR_FP	0x0100000000000000
> +#define TEXASR_DA	0x0080000000000000
> +#define TEXASR_NO	0x0040000000000000
> +#define TEXASR_FO	0x0020000000000000
> +#define TEXASR_SIC	0x0010000000000000
> +#define TEXASR_NTC	0x0008000000000000
> +#define TEXASR_TC	0x0004000000000000
> +#define TEXASR_TIC	0x0002000000000000
> +#define TEXASR_IC	0x0001000000000000
> +#define TEXASR_IFC	0x0000800000000000
> +#define TEXASR_ABT	0x0000000100000000
> +#define TEXASR_SPD	0x0000000080000000
> +#define TEXASR_HV	0x0000000020000000
> +#define TEXASR_PR	0x0000000010000000
> +#define TEXASR_FS	0x0000000008000000
> +#define TEXASR_TE	0x0000000004000000
> +#define TEXASR_ROT	0x0000000002000000
> Â
> Â#endif /* _SELFTESTS_POWERPC_REG_H */