Re: [PATCH v14 15/15] selftests/powerpc: Fix a build issue

[Cyril Bur]

On Mon, 2016-09-12 at 15:33 +0800, wei.guo.simon@xxxxxxxxx wrote:
> From: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
> 
> Fixes the following build failure -
> 
> cp_abort.c:90:3: error: âforâ loop initial declarations are only
> allowed in C99 or C11 mode
> ÂÂÂfor (int i = 0; i < NUM_LOOPS; i++) {
> ÂÂÂ^
> cp_abort.c:90:3: note: use option -std=c99, -std=gnu99, -std=c11 or
> -std=gnu11 to compile your code
> cp_abort.c:97:3: error: âforâ loop initial declarations are only
> allowed in C99 or C11 mode
> ÂÂÂfor (int i = 0; i < NUM_LOOPS; i++) {
> 
> Signed-off-by: Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Simon Guo <wei.guo.simon@xxxxxxxxx>

Reviewed-by: Cyril Bur <cyrilbur@xxxxxxxxx>

> ---
> Âtools/testing/selftests/powerpc/context_switch/cp_abort.c | 6 +++---
> Â1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git
> a/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> b/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> index 5a5b55a..1ce7dce 100644
> --- a/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> +++ b/tools/testing/selftests/powerpc/context_switch/cp_abort.c
> @@ -67,7 +67,7 @@ int test_cp_abort(void)
> Â	/* 128 bytes for a full cache line */
> Â	char buf[128] __cacheline_aligned;
> Â	cpu_set_t cpuset;
> -	int fd1[2], fd2[2], pid;
> +	int fd1[2], fd2[2], pid, i;
> Â	char c;
> Â
> Â	/* only run this test on a P9 or later */
> @@ -87,14 +87,14 @@ int test_cp_abort(void)
> Â	FAIL_IF(pid < 0);
> Â
> Â	if (!pid) {
> -		for (int i = 0; i < NUM_LOOPS; i++) {
> +		for (i = 0; i < NUM_LOOPS; i++) {
> Â			FAIL_IF((write(fd1[WRITE_FD], &c, 1)) != 1);
> Â			FAIL_IF((read(fd2[READ_FD], &c, 1)) != 1);
> Â			/* A paste succeeds if CR0 EQ bit is set */
> Â			FAIL_IF(paste(buf) & 0x20000000);
> Â		}
> Â	} else {
> -		for (int i = 0; i < NUM_LOOPS; i++) {
> +		for (i = 0; i < NUM_LOOPS; i++) {
> Â			FAIL_IF((read(fd1[READ_FD], &c, 1)) != 1);
> Â			copy(buf);
> Â			FAIL_IF((write(fd2[WRITE_FD], &c, 1) != 1));