Re: [PATCH 02/15] hisi_sas: save delivery queue write pointer

From: Hannes Reinecke
Date: Wed Sep 14 2016 - 07:47:45 EST


On 09/06/2016 05:36 PM, John Garry wrote:
> Optimise by saving an avoidable read in the
> get_free_slot function.
> The delivery queue write pointer will only be
> updated by software, so don't bother re-reading
> what was already written in the previous call
> to start_delivery function.
>
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> ---
> drivers/scsi/hisi_sas/hisi_sas.h | 7 +++++++
> drivers/scsi/hisi_sas/hisi_sas_main.c | 5 +++++
> drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 12 +++++++-----
> drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 9 ++++++---
> 4 files changed, 25 insertions(+), 8 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Cheers
--
Dr. Hannes Reinecke zSeries & Storage
hare@xxxxxxx +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)