Re: [PATCH] blockgroup_lock.h: remove debris from bgl_lock_ptr() conversion

[Andreas Dilger]

On Sep 14, 2016, at 1:27 PM, Eric Biggers <ebiggers@xxxxxxxxxx> wrote:
> 
> An obsolete comment and extra parentheses were left over from when the
> sb_bgl_lock() macro was replaced with the bgl_lock_ptr() function.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>

Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>

> ---
> include/linux/blockgroup_lock.h | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/include/linux/blockgroup_lock.h b/include/linux/blockgroup_lock.h
> index e44b88b..61b583d 100644
> --- a/include/linux/blockgroup_lock.h
> +++ b/include/linux/blockgroup_lock.h
> @@ -49,14 +49,10 @@ static inline void bgl_lock_init(struct blockgroup_lock *bgl)
> 		spin_lock_init(&bgl->locks[i].lock);
> }
> 
> -/*
> - * The accessor is a macro so we can embed a blockgroup_lock into different
> - * superblock types
> - */
> static inline spinlock_t *
> bgl_lock_ptr(struct blockgroup_lock *bgl, unsigned int block_group)
> {
> -	return &bgl->locks[(block_group) & (NR_BG_LOCKS-1)].lock;
> +	return &bgl->locks[block_group & (NR_BG_LOCKS-1)].lock;
> }
> 
> #endif
> --
> 2.8.0.rc3.226.g39d4020
> 


Cheers, Andreas

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail