RE: [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode

From: Appana Durga Kedareswara Rao
Date: Wed Sep 14 2016 - 23:59:35 EST




> -----Original Message-----
> From: Eugeniy Paltsev [mailto:Eugeniy.Paltsev@xxxxxxxxxxxx]
> Sent: Wednesday, September 14, 2016 11:11 PM
> To: dmaengine@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx; Appana Durga Kedareswara Rao
> <appanad@xxxxxxxxxx>; vinod.koul@xxxxxxxxx; dan.j.williams@xxxxxxxxx;
> andriy.shevchenko@xxxxxxxxxxxxxxx; linux-snps-arc@xxxxxxxxxxxxxxxxxxx; Eugeniy
> Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx>
> Subject: [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
>
> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for scatter-
> gather DMA mode") changes default "dmatest" behavior by changing default
> mode from "memcpy" to "scatter-gather".
> Now "memcpy" gets back as default mode.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@xxxxxxxxxxxx>

Reviewed-by: Kedareswara rao Appana <appanad@xxxxxxxxxx>


Thanks,
Kedar.

> ---
> drivers/dma/dmatest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index
> 53e9728..cf76fc6 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -56,10 +56,10 @@ module_param(sg_buffers, uint, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(sg_buffers,
> "Number of scatter gather buffers (default: 1)");
>
> -static unsigned int dmatest = 1;
> +static unsigned int dmatest;
> module_param(dmatest, uint, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(dmatest,
> - "dmatest 0-memcpy 1-slave_sg (default: 1)");
> + "dmatest 0-memcpy 1-slave_sg (default: 0)");
>
> static unsigned int xor_sources = 3;
> module_param(xor_sources, uint, S_IRUGO | S_IWUSR);
> --
> 2.5.5