Re: [PATCH 4/8] gpio: altera: fix implicit assumption module.h is present
From: Linus Walleij
Date: Thu Sep 15 2016 - 08:01:18 EST
On Tue, Sep 13, 2016 at 12:16 AM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:
> The Kconfig for this file is:
>
> drivers/gpio/Kconfig:config GPIO_ALTERA
> drivers/gpio/Kconfig: tristate "Altera GPIO"
>
> ...but however it does not include module.h -- it in turn gets it from
> another header (gpio/driver.h) and we'd like to replace that with a
> forward delcaration of "struct module;" but if we do, this file will
> fail to compile.
>
> So we fix this first to avoid putting build failures into the bisect
> commit history.
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Alexandre Courbot <gnurou@xxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Patch applied.
Yours,
Linus Walleij