Re: solo6010 modprobe lockup since e1ceb25a (v4.3 regression)

From: Hans Verkuil
Date: Thu Sep 15 2016 - 09:25:21 EST


On 09/15/2016 03:19 PM, Andrey Utkin wrote:
> On Thu, Sep 15, 2016 at 03:15:53PM +0200, Hans Verkuil wrote:
>> It could be related to the fact that a PCI write may be delayed unless
>> it is followed by a read (see also the comments in drivers/media/pci/ivtv/ivtv-driver.h).
>
> Thanks for explanation!
>
>> That was probably the reason for the pci_read_config_word in the reg_write
>> code. Try putting that back (and just that).
>
> In this case reg_write becomes not atomic, thus spinlock would be
> required again here, right?

That depends on whether you can have calls to this function in parallel.

But I get the feeling that it might be easier to just revert the patch.

Regards,

Hans