Re: [tip:x86/vdso] x86/vdso: Only define map_vdso_randomized() if CONFIG_X86_64

[Dmitry Safonov]

On 09/15/2016 01:44 PM, tip-bot for Ingo Molnar wrote:
> Commit-ID:  3947f49302e4d1576ee58addd8d20b477faef5ea
> Gitweb:     http://git.kernel.org/tip/3947f49302e4d1576ee58addd8d20b477faef5ea
> Author:     Ingo Molnar <mingo@xxxxxxxxxx>
> AuthorDate: Thu, 15 Sep 2016 08:56:21 +0200
> Committer:  Ingo Molnar <mingo@xxxxxxxxxx>
> CommitDate: Thu, 15 Sep 2016 09:44:32 +0200
>
> x86/vdso: Only define map_vdso_randomized() if CONFIG_X86_64
>
> ... otherwise the compiler complains:
>
>    arch/x86/entry/vdso/vma.c:252:12: warning: âmap_vdso_randomizedâ defined but not used [-Wunused-function]
>
> But the #ifdeffery here is getting pretty ugly, so move around
> vdso_addr() as well to cluster the dependencies a bit more.
>
> It's still not particulary pretty though ...
>
> Cc: Andy Lutomirski <luto@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Brian Gerst <brgerst@xxxxxxxxx>
> Cc: Denys Vlasenko <dvlasenk@xxxxxxxxxx>
> Cc: Dmitry Safonov <dsafonov@xxxxxxxxxxxxx>
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> Cc: Josh Poimboeuf <jpoimboe@xxxxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: gorcunov@xxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Cc: linux-mm@xxxxxxxxx
> Cc: oleg@xxxxxxxxxx
> Cc: xemul@xxxxxxxxxxxxx
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> ---

Thanks!

--
             Dmitry