Re: [PATCH -next] staging: android: ion: Fix return value check in hi6220_ion_probe()

[Laura Abbott]

On 09/14/2016 07:20 PM, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
>
> In case of error, the function ion_device_create() returns ERR_PTR() and
> never returns NULL. The NULL test in the return value check should be
> replaced with IS_ERR().

Acked-by: Laura Abbott <labbott@xxxxxxxxxx>

> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
>  drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> index f392db2..659aa71 100644
> --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> @@ -49,8 +49,8 @@ static int hi6220_ion_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, ipdev);
>
>  	ipdev->idev = ion_device_create(NULL);
> -	if (!ipdev->idev)
> -		return -ENOMEM;
> +	if (IS_ERR(ipdev->idev))
> +		return PTR_ERR(ipdev->idev);
>
>  	ipdev->data = ion_parse_dt(pdev, hisi_heaps);
>  	if (IS_ERR(ipdev->data))