[PATCH 1/7] Apply transparent_union attribute to union semun

From: Stafford Horne
Date: Fri Sep 16 2016 - 10:47:47 EST

From: Jonas Bonn <jonas@xxxxxxxxxxxx>

The syscall handler for semctl is written under the assumption that the
toolchain will pass "small" unions as function parameters directly instead
of by reference. The union semun is "small" and thus fits this description.

Since it is assumed that the union will be passed directly and not by
reference, it is safe to access the union members without going via

The OpenRISC architecture, however, passes all unions by reference, thus
breaking the above assumption.

The technically correct fix here is to mark the union as being transparent
so that the ABI of the union's first element determines the parameter
passing method and thus make explicit what's already implied in the function

Signed-off-by: Jonas Bonn <jonas@xxxxxxxxxxxx>
Signed-off-by: Stafford Horne <shorne@xxxxxxxxx>
include/uapi/linux/sem.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/uapi/linux/sem.h b/include/uapi/linux/sem.h
index dd73b90..aabe50f 100644
--- a/include/uapi/linux/sem.h
+++ b/include/uapi/linux/sem.h
@@ -48,7 +48,7 @@ union semun {
unsigned short __user *array; /* array for GETALL & SETALL */
struct seminfo __user *__buf; /* buffer for IPC_INFO */
void __user *__pad;
+} __attribute__ ((transparent_union));

struct seminfo {
int semmap;