Re: [PATCH v4 1/3] nvme/scsi: Remove power management support

From: J Freyensee
Date: Fri Sep 16 2016 - 19:37:59 EST

On Fri, 2016-09-16 at 11:16 -0700, Andy Lutomirski wrote:
> As far as I can tell, there is basically nothing correct about this
> code.ÂÂIt misinterprets npss (off-by-one).ÂÂIt hardcodes a bunch of
> power states, which is nonsense, because they're all just indices
> into a table that software needs to parse.ÂÂIt completely ignores
> the distinction between operational and non-operational states.
> And, until 4.8, if all of the above magically succeeded, it would
> dereference a NULL pointer and OOPS.
> Since this code appears to be useless, just delete it.

Acked-by: Jay Freyensee <james_p_freyensee@xxxxxxxxxxxxxxx>

> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx>
> ---