Re: [RFT] arm64 dts: exynos: Fix invalid GIC interrupt flags in exynos7

From: Krzysztof Kozlowski
Date: Sat Sep 17 2016 - 12:31:24 EST

On Sat, Sep 17, 2016 at 05:06:08PM +0530, Alim Akhtar wrote:
> Hi Krzysztof,
> On 09/17/2016 01:31 AM, Krzysztof Kozlowski wrote:
> >Interrupt of type IRQ_TYPE_NONE is not allowed for GIC interrupts and
> >generates an error:
> > genirq: Setting trigger mode 0 for irq 16 failed (gic_set_type+0x0/0x68)
> >
> >The GIC requires shared interrupts to be edge rising or level high.
> >Platform declares support for both. Choose level high everywhere.
> >
> >Reported-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>
> >Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> >Reported-by: Alban Browaeys <alban.browaeys@xxxxxxxxx>
> >Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> >Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> >---
> This patch does resolve the error reported in commit.
> Have booted on exynos7 board, things looks fine (have not done a extensive
> testing though).
> With the _Typo_ fixed as pointed by you, feel free to add
> Tested-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>
> On another note, please cc me if case you want to check/verify something on
> exynos7 platform. I almost missed this patch.

Great, thanks! I'll remember that.

Best regards,