Re: [PATCH] net: hns: add function declarations in hns_dsaf_mac.h

From: Arnd Bergmann
Date: Sun Sep 18 2016 - 16:38:37 EST

On Sunday, September 18, 2016 5:11:36 PM CEST Baoyou Xie wrote:
> We get 2 warnings when building kernel with W=1:
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:246:6: warning: no previous prototype for 'hns_dsaf_srst_chns' [-Wmissing-prototypes]
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c:276:6: warning: no previous prototype for 'hns_dsaf_roce_srst' [-Wmissing-prototypes]
> In fact, these two functions are not declared in any file, but should
> be declared in a header file, thus can be recognized in other file.
> So this patch adds the declarations into
> drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.h
> Signed-off-by: Baoyou Xie <baoyou.xie@xxxxxxxxxx>

Why can't these be declared static?