Re: [RFC PATCH v2 11/11] irqchip: mbigen: promote mbigen init

[Hanjun Guo]

On 2016/9/15 23:24, Marc Zyngier wrote:
> On 14/09/16 15:21, Hanjun Guo wrote:
> > From: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
> >
> > mbigen is an irqchip and it needs to be probed before
> > devices, same logic is used for SMMU and etc., let's
> > use arch_initcall instead of platform init for mbigen.
> >
> > Cc: Marc Zyngier <marc.zyngier@xxxxxxx>
> > Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> > Cc: Ma Jun <majun258@xxxxxxxxxx>
> > Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
> > ---
> >  drivers/irqchip/irq-mbigen.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c
> > index ca6add1..3a33de6 100644
> > --- a/drivers/irqchip/irq-mbigen.c
> > +++ b/drivers/irqchip/irq-mbigen.c
> > @@ -374,7 +374,11 @@ static struct platform_driver mbigen_platform_driver = {
> >  	.probe			= mbigen_device_probe,
> >  };
> >
> > -module_platform_driver(mbigen_platform_driver);
> > +static __init int mbigen_init(void)
> > +{
> > +	return platform_driver_register(&mbigen_platform_driver);
> > +}
> > +arch_initcall(mbigen_init);
> >
> >  MODULE_AUTHOR("Jun Ma <majun258@xxxxxxxxxx>");
> >  MODULE_AUTHOR("Yun Wu <wuyun.wu@xxxxxxxxxx>");
>
> I've already NACKed such a patch in the past, and I will carry on
> NACKing it until all the other avenues (like properly tracking device
> dependencies) have been explored and have been proven not to be fit for
> purpose.

I'd happy to work on this to make progress.

> Rafael had proposed something around this subject last year, and I've

Sorry, obviously I missed something, could you give me the link about
Rafael's patches? I will pull back and test it on our hardware.

> been repeatedly advising you to work with him and others to make it
> happen. You can choose to ignore this advise, but that doesn't make this
> patch an acceptable approach.

OK, I will drop this patch in next version, and work on the generic
solution instead.

Thanks
Hanjun