Re: [PATCH] sbitmap: initialize weight to zero

From: Jens Axboe
Date: Mon Sep 19 2016 - 10:21:23 EST


On 09/19/2016 07:34 AM, Colin King wrote:
From: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Variable weight is not being initialized to zero before it is
used to compute the weight sum. Ensure it is initialized to zero.

Found with static analysis with cppcheck:
[lib/sbitmap.c:177]: (error) Uninitialized variable: weight

Thanks, applied. Strange, this is an old issue, it was just moved to this file. It should have triggered on mainline too. My compiler doesn't complain here:

$ gcc --version
gcc (Ubuntu 6.2.0-3ubuntu11~16.04) 6.2.0 20160901

--
Jens Axboe